Fix: NPM GH release publishing should set latest #2423
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackw
force-pushed
the
jackw/fix-npm-latest-release
branch
from
63fe781 to
fce0e96
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2423 +/- ##
==========================================
- Coverage 85.92% 80.58% -5.34%
==========================================
Files 69 69
Lines 5675 5675
Branches 1332 1274 -58
==========================================
- Hits 4876 4573 -303
- Misses 718 719 +1
- Partials 81 383 +302 ☔ View full report in Codecov by Sentry. |
|
Seems like a duplicate of my fix #2414 |
|
@hipstersmoothie I combined the contents from this PR to my PR if you could have a look 🙏 #2414 |
|
Let's close this as @jazmon has gone to the trouble of bringing the two together. Awesome work everybody! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Updated the NPM plugin to set
nextReleaseflag when callinggit.publish.Why
It looks like GH releases in the NPM plugin aren't using the
nextReleaseflag that was introduced in #2391fixes: #2422
Todo:
Change Type
Indicate the type of change your pull request is:
documentationpatchminormajor